fix: follow setting when quick scheduling next week (#3373) #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miqh
commented
Oct 6, 2024
src/app/features/planner/dialog-schedule-task/dialog-schedule-task.component.ts
Show resolved
Hide resolved
miqh
commented
Oct 6, 2024
src/app/features/planner/dialog-schedule-task/dialog-schedule-task.component.ts
Show resolved
Hide resolved
|
Thank you very much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello there,
I tried scouring history for context around why the quick action for scheduling a task forces it to always be the following Monday, but it's still not clear to me why. The following commit appears to be the original appearance:
8822001
The proposed changes here should ensure that the
FIRST_DAY_OF_WEEKsetting is respected.Though one might argue that rather than abide by the setting, the action should instead be today's date plus seven days.
Anyway, I'm happy to revise as necessary. I was going to pull out the rather similar logic for establishing the scheduled date into a utility function, but thought I'd solicit feedback first.
Issues Resolved
#3373
Check List