Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error with max. value for Tilt Angle #419

Closed
granturism0 opened this issue Dec 26, 2021 · 8 comments
Closed

[BUG] Error with max. value for Tilt Angle #419

granturism0 opened this issue Dec 26, 2021 · 8 comments
Assignees

Comments

@granturism0
Copy link

Hi @johannrichard
In my logs i see a lot of this errors: [homebridge-dingz] This plugin generated a warning from the characteristic 'Current Horizontal Tilt Angle': characteristic was supplied illegal value: number 100 exceeded maximum of 90. See https://git.io/JtMGR for more info.
I think something is wrong with the maximum value.
PS: I use the latest firmware (1.3.30)
Greetings,
Granturismo

@granturism0 granturism0 added the bug Something isn't working label Dec 26, 2021
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.2.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@johannrichard johannrichard changed the title [BUG]Error with max. value for Tilt Angle [BUG] Error with max. value for Tilt Angle Oct 24, 2022
@johannrichard
Copy link
Owner

I know it's been a while since you reported the bug. In case you still use the plugin, I'd be grateful if you could check whether the beta indeed solves the issues here.

@johannrichard
Copy link
Owner

I know it's been a while since you reported the bug. In case you still use the plugin, I'd be grateful if you could check whether the beta indeed solves the issues here.

N.B.: I tried to test it as much as possible. What's irritating me: if I move the slider in the Dingz WebUI to 100%, HomeKit will indeed display the maximum tilt angle of 90°. However, the slider just above that will display a value less than the maximum. OTOH, if I move the HomeKit Slides to 100% while the value of the angle is less than 90°, everything moves as well, but if I move the slider to the max, it somehow stalls.

IMG_376E520CFCA2-1

johannrichard added a commit that referenced this issue Oct 24, 2022
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.2.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@johannrichard
Copy link
Owner

Did some more tests (and tweaks to the code). The warnings are (mostly IMHO) gone now and the values set should now be all converted between ° and % (and vice-versa) at the right place.

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.2.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

johannrichard added a commit that referenced this issue Oct 24, 2022
Prepare 3.2.0-beta 
- fixing #511, #419 and refactoring code and reducing noise as well.
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants