Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data resource locations #15

Merged

Conversation

tomviner
Copy link
Contributor

@tomviner tomviner commented Nov 2, 2019

I found I could not use Maven to collect data from the electoral commission website because 2 URLs no longer worked.

  1. The uk_2010_results data is no longer on the electoral commission website due to their policy:

We publish information about the most recent election or referendum, and the one before it. For example, you'll find information about the UK general elections that took place in 2017 and in 2015.

From https://www.electoralcommission.org.uk/who-we-are-and-what-we-do/elections-and-referendums/past-elections-and-referendums

  1. The uk_2015_results URL has changed.

@tomviner tomviner marked this pull request as ready for review November 2, 2019 23:12
@tomviner tomviner mentioned this pull request Nov 2, 2019
@john-sandall
Copy link
Owner

On the plus side, they've had a major site redesign and the data they do have looks a lot easier to find. On the negative side, why would they take down such fundamental and important data!

I'm not especially comfortable using the S3-hosted backup here as primary data source, but it'll have to do until we can find a new primary.

Thanks for doing this.

@john-sandall john-sandall merged commit 346254f into john-sandall:master Nov 14, 2019
@john-sandall john-sandall mentioned this pull request Nov 14, 2019
@tomviner tomviner deleted the fix-data-resource-locations branch November 16, 2019 00:04
@tomviner tomviner restored the fix-data-resource-locations branch November 16, 2019 00:04
@tomviner tomviner deleted the fix-data-resource-locations branch November 16, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants