Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jones project 4 #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Arachnophobian
Copy link
Collaborator

I had three approving reviews on my other branch... but then I couldn't assign it to your repository, I had to commit it to mine directly, and then open a new pull request?

I've only created the two questions/answers so far, but I plan to try to make more if I can.
Copy link
Owner

@johnbeve johnbeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a few kata

PREFIX dbr: http://dbpedia.org/resource
PREFIX rdf: http://www.w3.org/1999/02/22-rdf-syntax-ns#

SELECT ?Concept dbr:Barack_Obama
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to include the IRI in the SELECT clause

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I definitely was not quite following, but I remember that Giacomo pointed this out after I had submitted. I thought I had fixed it, but it seems that what I had pushed was the incorrect one.

PREFIX dbr: http://dbpedia.org/resource
PREFIX rdf: http://www.w3.org/1999/02/22-rdf-syntax-ns#

SELECT distinct ?Concept dbr:Barack_Obama
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to include the IRI in the SELECT clause

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

WHERE
{
dbr:Barack_Obama a ?Concept .
FILTER (regex(?Concept, "cit","i"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filter would keep everything that Obama was a type of that included - roughly speaking - "cit" in its label, e.g. Obama is tacit. Was that your intent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my intent, yes, but I do realize that it might return anything that isn't a city too... still, I thought it would be sufficient to prove the point that not everything that is returned is actually about Obama.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants