Make compatible with phpunit 7.x #41
Conversation
…xist anymore. Also, implement newer listener interface
|
great job, eager to see it happen ! |
| "php": ">=7.0", | ||
| "phpunit/phpunit": "^6.0" | ||
| "php": ">=7.1", | ||
| "phpunit/phpunit": "^7.0" |
There was a problem hiding this comment.
@luispabon You could also support ^6.4|^7.0 with this.
There was a problem hiding this comment.
no you can't.
PHPUnit 6 doesn't have typehinting, PHPUnit 7 does, if you want to support both, you need to provide 2 versions of class and load one depends on PHPUnit version
There was a problem hiding this comment.
as keradus said it cannot be done due to interfaces being completely incompatible due to the newer php7.1 type hints. You would need two implementations, and that's what semver+composer already give us.
There was a problem hiding this comment.
Ah yeah... totally overlooked the additional typehints in 7.0.
|
@johnkary Any eta on this? |
|
@luispabon Thank you so much for your work to add PHPUnit 7 support. This works wonderfully and we'll move forward tagging a 3.0 based on this work. Also thank you to other contributors for your PR feedback. |
Since this is a BC break, a release with this code will need tagging as 3.0.