Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for varying mlr locations #1086

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Aug 23, 2022

The expected error output for the "not-a-valid-timezone" test assumes
that mlr is invoked as mlr. Use "${MLR}" instead to cope with any
invocation path.

This also adds a regression test to catch future instances before they
get merged.

Signed-off-by: Stephen Kitt [email protected]

The expected error output for the "not-a-valid-timezone" test assumes
that mlr is invoked as mlr. Use "${MLR}" instead to cope with any
invocation path.

This also adds a regression test to catch future instances before they
get merged.

Signed-off-by: Stephen Kitt <[email protected]>
@skitt
Copy link
Contributor Author

skitt commented Aug 23, 2022

#1085 shows the regression test doing its job (failing because of the test assuming mlr).

@johnkerl
Copy link
Owner

awesome, thanks @skitt !! :D

@johnkerl johnkerl merged commit cdbe8b8 into johnkerl:main Aug 23, 2022
johnkerl added a commit that referenced this pull request Aug 25, 2022
johnkerl added a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants