Separate out ILineReader abstraction
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/tsv-64k-fix
branch
from
c3ce03c
to
3979dfa
Compare
johnkerl
force-pushed
the
kerl/tsv-64k-fix
branch
from
3979dfa
to
bb8763c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #1501 there is a bug report invoiving
bufio.Scannermisbehaving on lines with more than 65,536 characters. I'll be replacing my use ofbufio.Scannerwithin Miller'spkg/input/. But first, on this PR, I insert an abstraction layer to make the swap-out easier to code and test.