Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More dead code removal #905

Merged
merged 1 commit into from
Jan 30, 2022
Merged

More dead code removal #905

merged 1 commit into from
Jan 30, 2022

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Jan 28, 2022

Some of these might indicate bugs...

@skitt
More dead code removal
7105d82 
Signed-off-by: Stephen Kitt <[email protected]>
@johnkerl
Copy link
Owner

Some of these might indicate bugs...

Indeed @skitt ... the break semantics are different in Go -- better than most older languages, IMNSHO!! ;) -- and those are clearly OK. But, agreed, waitAndClose() not being called ... maybe it should be ... :^/

@johnkerl
Copy link
Owner

johnkerl commented Jan 30, 2022 •
edited
Loading

@skitt this is all fine. In particular the readpipe.Close is done elsewhere (above, in the same file) so removing waitAndClose is fine.

On a future PR I'll probably re-add func (keeper *JoinBucketKeeper) dump(prefix string), along with some unit-test callsite to make sure it doesn't get reaped again -- this will be helpful on #173 and #711.

Thank you as always!!! :D

@johnkerl johnkerl merged commit 1beacbd into johnkerl:main Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skitt @johnkerl