Skip to content

Commit

Permalink
fixup! add support for browser profiles
Browse files Browse the repository at this point in the history
  • Loading branch information
bhedavivek committed Jun 15, 2020
1 parent fd74d7d commit 8749d0f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Finicky/Finicky/finickyConfigAPI.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ let finickyConfigApi = (() => {
name: validate.string.isRequired,
appType: validate.oneOf(["appName", "appPath", "bundleId"]),
openInBackground: validate.boolean,
profile: validate.string,
profile: validate.string
}), validate.function("options"), validate.value(null)]);
const multipleBrowsersSchema = validate.oneOf([browserSchema, validate.arrayOf(browserSchema.isRequired)]);
const matchSchema = validate.oneOf([validate.string, validate.function("options"), validate.regex, validate.arrayOf(validate.oneOf([validate.string, validate.function("options"), validate.regex]))]);
Expand Down
1 change: 1 addition & 0 deletions config-api/src/processUrl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const appDescriptorSchema = {
validate.value("none"),
]).isRequired,
openInBackground: validate.boolean,
profile: validate.string,
};

export function processUrl(
Expand Down
4 changes: 3 additions & 1 deletion config-api/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export interface BrowserObject {
name: string;
appType?: "appName" | "bundleId" | "appPath" | "none";
openInBackground?: boolean;
profile: string;
}

/**
Expand Down Expand Up @@ -191,7 +192,8 @@ const browserSchema = validate.oneOf([
validate.shape({
name: validate.string.isRequired,
appType: validate.oneOf(["appName", "appPath", "bundleId"]),
openInBackground: validate.boolean
openInBackground: validate.boolean,
profile: validate.string,
}),
validate.function("options"),
validate.value(null)
Expand Down

0 comments on commit 8749d0f

Please sign in to comment.