Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssn)Add support uk_Ua ssn method birthday and gender optional pa… #1983

Merged

Conversation

lozik4
Copy link
Contributor

@lozik4 lozik4 commented Jan 28, 2024

Now the ssn for the uk_Ua locale can generate values for a specific gender and date of birth.

Add optional params birthdate and gender.
Customize logic generation and write tests.

What was wrong

Many validators in Ukraine check the ssn together with the date of birth, the previous implementation does not allow to pass validation, because the method takes a random date of birth. Gender was not taken into account at all.
Now it is possible to generate the desired value more accurately. If this is not necessary, the old logic will work.

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 6f59874 into joke2k:master Jan 29, 2024
28 checks passed
@lozik4 lozik4 deleted the feat/ua_uk/ssn_with_birthdate_and_gender branch February 26, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants