Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
@joken_default_signer
as a module attribute requires that the config is set at compile time. This means that should a secret key be compromised, the user must recompile the whole application. Moving theparse_config
method into the existing__default_signer__
method will allow the user to swap out the config without recompiling the app.Also, in our case and maybe others, besides wanting to be able to swap out the key without recompiling, it's a pain to ensure that environment variables are even available at compile time. Which is more our own problem, but still.
Fixes #211