Plural time units are deprecated >= elixir1.8 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: deprecated time unit: :nanoseconds. A time unit should be :second, :millisecond, :microsecond, :nanosecond, or a positive integer
|
Can we wait a bit longer to merge this so that we can add 1.8 to Travis? I don't think 1.8 is available there yet |
|
Afaik it is already available on travis :) See for example https://github.com/appsignal/appsignal-elixir/blob/develop/.travis.yml I can add it as well if you want? |
|
Wow! That was fast :) Yeah please do it! |
Exclude elixir 1.8 with otp 1.9.3 as this is not supported https://hexdocs.pm/elixir/compatibility-and-deprecations.html#compatibility-between-non-major-elixir-versions
|
Done :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get this warning when compiling in elixir 1.8
warning: deprecated time unit: :nanoseconds. A time unit should be :second, :millisecond, :microsecond, :nanosecond, or a positive integer