Allow custom error messages on claim validation #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tgturner this is an awesome addition. I am all for it. I was just thinking that maybe a Also the build broke cause |
|
@victorolinasc Thanks for getting back to me! I updated the PR to use a Keyword list instead of a map. That does seem appropriate. I also made sure to run |
victorolinasc
approved these changes
Mar 14, 2019
|
Thanks @victorolinasc! And thanks for working on Joken, it has been a real pleasure to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to 2.x, using
with_validationwould allow you to set a custom error message. The ability, as far as I can tell, was lost in 2.x. The PR would bring back some of the functionality. I'm open to any suggested changes!