fix: treat improper token properly #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request originated from a Joken crash when sending invalid tokens that contained two ".", like
a.a.a
or..
. These tokens match correctly on[_, _, _] = String.split(token, ".")
, thus passing a first validation layer (Joken.expand(token)
).Furthermore, when using
before_verify
orbefore_validate
hooks that usedJoken.peek_claims
orJoken.peek_header
, there could be a problem where said invalid tokens would bleed through as{:ok, :error}
, thus causing the crash (as it was expected to return{:ok, %{} = claims}
instead of{:ok, atom}
)Fix
Instead of relying on just passing through the
Base.decode64
error return, it needs to be wrapped as a{:error, improper_token}
tuple.The test added ensures that both scenarios are now returning an error as expected