Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three issues I encountered.
Joken.Hooks.RequiredClaims
had an example which wrapped the required claims in a keyword list, but the hook required just a plain list. I changed the docs. However, the Joken.Hooks behaviour asks for a keyword list as the first argument for all callbacks, so it would probably be better to change the implementation, although that would be a breaking change. If you prefer that, let me know and I'll change it.Joken.Jwks
requires you to set the default signer tonil
. If you callJoken.verify_and_validate/5
etc. directly and passnil
as a signer, you will get a dialyzer error. I changed the type specs of all those functions to allownil
as signer.