Clean ups and fixes #389
Merged
Clean ups and fixes #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
victorolinasc
commented
Jan 29, 2023
victorolinasc
commented
- Up minimum version (JOSE supports only 1.13+)
- Use import Config and not use Mix.Config
- Fix typ not being overwritable
- Update deps
- Eliminate warnings
victorolinasc
force-pushed
the
clean_ups_and_fixes
branch
3 times, most recently
from
d75bede
to
673d22e
Compare
- Up minimum version (JOSE supports only 1.13+) - Use import Config and not use Mix.Config - Fix typ not being overwritable - Update deps - Fix CI and other `master` branch references
victorolinasc
force-pushed
the
clean_ups_and_fixes
branch
from
673d22e
to
f290e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.