Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted readme #2

Conversation

jolo-dev
Copy link
Owner

@jolo-dev jolo-dev commented Nov 30, 2023

REPLACE THIS TEXT BLOCK

Describe the reason for this change, what the solution is, and any
important design decisions you made.

Remember to follow the CONTRIBUTING GUIDE and DESIGN GUIDELINES for any
code you submit.

Closes #.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


Generated summary (powered by Graphite)

Pull Request Description

TL;DR

This pull request refactors the aws-codepipeline-actions README.md file to use a declared lambdaFunction instead of creating a new one within the CodeCommitSourceAction declaration.

What changed

The CodeCommitSourceAction declaration in the README.md file of aws-codepipeline-actions package was updated. Instead of creating a new LambdaFunction within the target field, it now uses a previously declared lambdaFunction.

-    target: new LambdaFunction(new Function(stack, 'TestFunction', {
-      code: Code.fromInline('foo'),
-      handler: 'bar',
-      runtime: Runtime.NODEJS_LATEST,
-    })),
+    target: lambdaFuntion,

How to test

To test this change, follow the instructions in the README.md file to set up a CodeCommitSourceAction using a lambdaFunction. Ensure that the pipeline works as expected with the lambdaFunction as the target.

Why make this change

This change simplifies the code and makes it easier to understand. It also promotes the use of declared variables, which can be more efficient and easier to manage in larger codebases.

@jolo-dev
Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Owner Author

@jolo-dev jolo-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@jolo-dev jolo-dev merged commit 26771fc into jolo-dev/custom-event-for-codepipeline-codecommit-actions Nov 30, 2023
14 of 17 checks passed
@jolo-dev jolo-dev deleted the 11-30-Adjusted_readme branch November 30, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant