Make it possible to use our own initialize and some other improvements #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
force-pushed
the
pinned-js
branch
2 times, most recently
from
dcb85e2
to
9158107
Compare
A couple of improvements are introduced here. - Be able to pin what version of StimulusReflex we are using. The tradeoff is that we need to maintain a fork that is lightly touched to allow for that functionality. - Be able to decouple from how rails expect the identifier would look like - The javascript code for actioncable is no longer a dependency.
|
@DamnedScholar Perhaps you could have a look at this and let me know if you have any thoughts? |
|
Thank you. I will probe it when I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Description
A couple of improvements are introduced here.
tradeoff is that we need to maintain a fork that is lightly touched
to allow for that functionality.
like
Checklist