Make it possible to use dot notation for setting context in reflex #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
force-pushed
the
context-dict
branch
2 times, most recently
from
b1778e1
to
a9bff7d
Compare
jonathan-s
changed the title
jonathan-s
changed the title
jonathan-s
force-pushed
the
context-dict
branch
2 times, most recently
from
59b6d8d
to
fbee544
Compare
dylanjw
reviewed
Jul 30, 2021
dylanjw
reviewed
Jul 31, 2021
In an effort to improve the api for setting the context that is used in the final context in the reflex we introduce a dot notation for setting the context. Ie `reflex.context.my_context = 'value'`. For the old way of setting the context in instance variables you now also prevented to set an instance variable that is already used by the reflex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Description
In an effort to improve the api for setting the context that is
used in the final context in the reflex we introduce a dot notation
for setting the context. Ie
reflex.context.my_context = 'value'.For the old way of setting the context in instance variables you
now also prevented to set an instance variable that is already used
by the reflex.
Fixes #122, @dylanjw, you might want to have a look at this.
Checklist