Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Add fingerprintCheck option and documentation #21

Conversation

mwpastore
Copy link
Contributor

Final fixes for issue #20!

@mwpastore
Copy link
Contributor Author

Hrrm, does that normally happen?

@jonathanKingston
Copy link
Owner

Nope, I think it has before. Could you try committing like a line change or something that does a change without causing linting issues and push -f?

@mwpastore
Copy link
Contributor Author

Hi Jonathan, I had a quick chat with @rwjblue. He pointed me to this blog post and suggested we either bump the default Ember version or lock the jQuery version. I took the latter approach and it looks like that did the trick!

@mwpastore
Copy link
Contributor Author

Hi @jonathanKingston, just a friendly poke/prod that this is ready to go, as far as I know. 😃 Thank you in advance!

@jonathanKingston
Copy link
Owner

Sounds good enough for me if it is good enough for @rwjblue.
I left the options out of ember-cli-sri as I figured it was already complex enough however that isn't a blocker and I probably was wrong. At the time of development SRI was still being standardised so I thought it was best not to confuse people.
Thanks!

jonathanKingston added a commit that referenced this pull request Feb 18, 2016
Add fingerprintCheck option and documentation
@jonathanKingston jonathanKingston merged commit 50ab509 into jonathanKingston:master Feb 18, 2016
@mwpastore mwpastore deleted the add-fingerprint-check-option branch February 18, 2016 08:00
@mwpastore
Copy link
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants