Improve IPv4 and IPv6 address handling #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
3 times, most recently
from
b5d0bad
to
01ddf0f
Compare
tomeon
commented
Apr 13, 2022
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
2 times, most recently
from
9506ce7
to
834b3bf
Compare
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
from
834b3bf
to
451e782
Compare
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
from
1dcf2be
to
838fd3d
Compare
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
2 times, most recently
from
ee733d6
to
1e8c18f
Compare
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
from
aa75e00
to
147f375
Compare
by:
1. Farming out address expansion and validation to battle-tested
tools, when possible (sipcalc, Python's "ipaddress" module),
2. Making native IPv6 expansion and validation handle a wider
variety of address representations (not just what is allowed by
RFC 5952),
3. Fixing various bugs in the native IPv6 address expansion
routines,
4. Making the native IP expansion routines log _why_ address
expansion failed, when it failed, and
5. Adding a variety of test cases to show that addresses are
expanded properly and that the different expansion
implementations (Python, sipcalc, and native) agree with one
another.
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
from
147f375
to
79e91f4
Compare
and Bash >= 4.3 requirement in the changelog.
tomeon
force-pushed
the
improve-ip-expansion-and-validation
branch
from
79e91f4
to
8c5bd54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Atoning for the sins I committed in #3, and addressing #71.
Summary of changes
sipcalc, Python'sipaddressmodule),sipcalc, and native) agree with one another.Caveats and Reservations
Complexity
There is a significant quotient of incidental complexity here, especially around testing for whether Python/
ipaddressand/orsipcalcare available. This PR would be half as large if it were limited to just Bash-native address handling.Maybe any Python stuff should wait for #57?
Differences of opinion
sipcalcdoes not like addresses in the form::1:2:3:4:5:6:7or1:2:3:4:5:6:7::, whereas Python'sipaddressmodule likes them just fine. I've made the native expansion routine accept them as well. Not sure what the right call is, but it does seem wrong to me thatupdate-systemd-resolvedwould accept an address in some system configurations (Python available, or neither Python norsipcalcavailable) but not others (Python not available,sipcalcavailable).