Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Release Notes Button on Homepage #529

Closed
Senay-Ersen opened this issue Jul 24, 2023 · 6 comments · Fixed by #535
Closed

View Release Notes Button on Homepage #529

Senay-Ersen opened this issue Jul 24, 2023 · 6 comments · Fixed by #535
Assignees
Labels
Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Type: Bug Something isn't working

Comments

@Senay-Ersen
Copy link

Senay-Ersen commented Jul 24, 2023

Package Edition of Nebula Logger

Unlocked Package

Package Version of Nebula Logger

v4.10.6

New Bug Summary

Hi @jongpie,

After deploying Nebula Logger Unlocked package to a higher environment, we see the View Release Notes button as in the below image and when we click it, we get 404 error. Also, when we click the View Environment Details button, the popup page comes up empty. What might I be missing to deploy/configure?

Note: The user has Logger: Admin permission set.

Thank you very much.

ViewEnvDetailsBtn
viewReleaseNotesBtn

@Senay-Ersen Senay-Ersen added the Type: Bug Something isn't working label Jul 24, 2023
@jongpie
Copy link
Owner

jongpie commented Jul 25, 2023

Hi @Senay-Ersen - there was a bug in v4.10.6 for the homepage header component, caused by users not having access to the new Apex controller class LoggerHomeHeaderController. If you can upgrade to v4.11.0, that should resolve these issues.

@Senay-Ersen
Copy link
Author

Hi @jongpie.
I have upgraded Nebula Logger to v4.11.0 in Dev Org and deployed it to QA Org. Everything is fine in Dev but there is still the same problem in QA. When we click on the View Environment Details button, the pop up still comes up empty. Nebula Logger: Admin permission set has access to LoggerHomeHeaderController class but it seems like the environment variable returns empty/null from getEnvironmentDetails method and it causes showReleaseNotesButton variable to set to false and the button does not show up on the page. I am still trying to figure out what I might be missing to deploy, and, in the meantime, I wanted to reach out to you hoping you have any idea on that.

Thanks.

image

@jongpie
Copy link
Owner

jongpie commented Aug 3, 2023

Hey @Senay-Ersen that's very strange - the controller method is supposed to always return an non-empty/non-null object, so it's possible that there's an exception occurring when the LWC calls the controller method. Could you try calling the controller method from anonymous apex to see if that works for you? You can run something like this snippet to call the controller method:

System.debug('environment details result: ' + JSON.serializePretty(LoggerHomeHeaderController.getEnvironmentDetails()));

@Senay-Ersen
Copy link
Author

Hi @jongpie. I executed the code snippet you have written, and it gives me 'System.CalloutException: Unauthorized endpoint, please check Setup->Security->Remote site settings.' exception. It made me realize that Remote Site Setting metadata component was not deployed to QA. Once it is deployed, the problem will be resolved. Thanks a lot once more!

@jongpie
Copy link
Owner

jongpie commented Aug 7, 2023

Hi @Senay-Ersen, thanks for testing that out! I think this is a bug, so I'll include in a small bugfix in the next release - that callout integration is optional, and in some orgs, they prefer to have the remote site setting deactivated, so I think the code should handle situations where the callout fails. I'm hoping to finish the next release this week.

@jongpie jongpie added Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine labels Aug 7, 2023
@jongpie jongpie self-assigned this Aug 7, 2023
jongpie added a commit that referenced this issue Aug 7, 2023
jongpie added a commit that referenced this issue Aug 8, 2023
* Added new methods/overloads Logger.exception() that automatically log, save, and throw the provided exception

* Fixed some issues with exception-throwing in FlowLogger & added some additional tests

* Fixed #529 by adding a try-catch block in Logger.callStatusApi() and returning null when exceptions occur

* Scope creep: updated some tests in Logger_Tests to not be aware of the log-management layer

* Updated some ApexDocs comments in Logger

* Eliminated npm depedency on sfdx and upgraded sf CLI to v2

* Fixed some dependabot alerts in package.json / package-lock.json
@jongpie
Copy link
Owner

jongpie commented Aug 8, 2023

@Senay-Ersen this should now be fixed in the latest release, v4.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants