Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue 527 - update scripts to use @salesforce/cli (SF cli) #532

Merged

Conversation

JMercie
Copy link
Contributor

@JMercie JMercie commented Jul 31, 2023

As mentioned in issue #527, I updated existing scripts in the repository to use SF CLI instead of SFDX CLI to move to the recommended command line tool for Salesforce development, which is the one getting maintained currently.

Each script was replaced with its SF cli counterpart as detailed in the documentation

@JMercie JMercie marked this pull request as ready for review July 31, 2023 00:41
@JMercie JMercie requested a review from jongpie as a code owner July 31, 2023 00:41
@JMercie
Copy link
Contributor Author

JMercie commented Jul 31, 2023

@jongpie This PR is ready for review whenever you find time to. Thanks in advance for the time and for any recommendation

Copy link
Owner

@jongpie jongpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JMercie thanks for working on this! I read through the changes, and overall, things look great. There were a few items that I have feedback for - I've added comments about possible changes. Please let me know if you have any questions!

scripts/build/create-and-install-package-version.ps1 Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/build/create-scratch-org.ps1 Outdated Show resolved Hide resolved
scripts/build/create-scratch-org.ps1 Outdated Show resolved Hide resolved
scripts/build/get-devhub-org-details.ps1 Outdated Show resolved Hide resolved
@JMercie
Copy link
Contributor Author

JMercie commented Aug 5, 2023

Hey @jongpie

Thanks a lot for the feedback on this!

I also modified a few other commands beyond the ones you suggested. I used the abbreviature for the parameters; now, every command should use the long version.

I reverted the changes in the README.md and create-and-install-package-version.ps1 files, added back the sfdx-cli to the Dev dependencies in the package.json and downgrade the SF cli to 1.87.0 version because until we only want to use the SF cli we won't be able to use the v2 of it.

I hope everything looks better, and if you have any further comments on what has to be changed, I will work on it!

Copy link
Owner

@jongpie jongpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JMercie thanks so much for incorporating those changes! 🥳 I've re-reviewed the PR, and I think everything looks great to me. I'll merge this to main now, and then I'll test the build.yml changes in my open PR #535.

@jongpie jongpie added Type: Enhancement New feature or request devops Items related to tooling, automation, and guidelines used for developing Nebula Logger labels Aug 7, 2023
@jongpie jongpie merged commit 7603057 into jongpie:main Aug 7, 2023
@JMercie
Copy link
Contributor Author

JMercie commented Aug 8, 2023

@JMercie thanks so much for incorporating those changes! 🥳 I've re-reviewed the PR, and I think everything looks great to me. I'll merge this to main now, and then I'll test the build.yml changes in my open PR #535.

Thank you very much for letting people help on this project and for your review on the work!

Looking forward to keep contributing on this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants