-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Jest test failures not surfaced in pipeline #739
Merged
jongpie
merged 4 commits into
main
from
bugfix/jest-test-failures-not-surfaced-in-pipeline
Aug 22, 2024
Merged
Bugfix: Jest test failures not surfaced in pipeline #739
jongpie
merged 4 commits into
main
from
bugfix/jest-test-failures-not-surfaced-in-pipeline
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce lightning lwc test run' returns 0 exit code for failures :'(
jongpie
added
Type: Bug
Something isn't working
Logging Source: Lightning Components
Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura)
tests
Relates to Apex or LWC jest tests
pipeline
labels
Aug 22, 2024
jongpie
had a problem deploying
to
Experience Cloud Scratch Org
August 22, 2024 18:36
— with
GitHub Actions
Error
jongpie
had a problem deploying
to
Base Scratch Org
August 22, 2024 18:36
— with
GitHub Actions
Error
These were previously failing, but weren't being reported by the pipeline
jongpie
had a problem deploying
to
Base Scratch Org
August 22, 2024 18:43
— with
GitHub Actions
Failure
jongpie
had a problem deploying
to
Experience Cloud Scratch Org
August 22, 2024 18:43
— with
GitHub Actions
Error
jongpie
temporarily deployed
to
Base Scratch Org
August 22, 2024 18:47
— with
GitHub Actions
Inactive
jongpie
temporarily deployed
to
Experience Cloud Scratch Org
August 22, 2024 18:47
— with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 95.44% 93.18% -2.27%
==========================================
Files 51 67 +16
Lines 5620 6939 +1319
Branches 0 197 +197
==========================================
+ Hits 5364 6466 +1102
- Misses 256 445 +189
- Partials 0 28 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jongpie
added
devops
Items related to tooling, automation, and guidelines used for developing Nebula Logger
and removed
pipeline
labels
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
Items related to tooling, automation, and guidelines used for developing Nebula Logger
Logging Source: Lightning Components
Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura)
tests
Relates to Apex or LWC jest tests
Type: Bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sfdx-lwc-jest
for running jest tests - usingsf force lightning lwc test run
returns 0 exit code for failures, so failures weren't being surfacedpackage.json
logger
LWC - these were previously failing due to some asserts being out of date due to the changes made in releasev4.13.17
, but weren't being reported by the pipeline