Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Jest test failures not surfaced in pipeline #739

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Aug 22, 2024

  • Switched back to using sfdx-lwc-jest for running jest tests - using sf force lightning lwc test run returns 0 exit code for failures, so failures weren't being surfaced
  • Fixed some failing Jest tests for logger LWC - these were previously failing due to some asserts being out of date due to the changes made in release v4.13.17, but weren't being reported by the pipeline

@jongpie jongpie added Type: Bug Something isn't working Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) tests Relates to Apex or LWC jest tests pipeline labels Aug 22, 2024
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org August 22, 2024 18:36 — with GitHub Actions Error
These were previously failing, but weren't being reported by the pipeline
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (6664ed1) to head (67b839c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   95.44%   93.18%   -2.27%     
==========================================
  Files          51       67      +16     
  Lines        5620     6939    +1319     
  Branches        0      197     +197     
==========================================
+ Hits         5364     6466    +1102     
- Misses        256      445     +189     
- Partials        0       28      +28     
Flag Coverage Δ
Apex 95.44% <ø> (ø)
LWC 83.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie merged commit 17c6b7a into main Aug 22, 2024
1 check passed
@jongpie jongpie deleted the bugfix/jest-test-failures-not-surfaced-in-pipeline branch August 22, 2024 19:30
@jongpie jongpie added devops Items related to tooling, automation, and guidelines used for developing Nebula Logger and removed pipeline labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) tests Relates to Apex or LWC jest tests Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants