Mark Operation enum as non_exhaustive #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 78.65% 78.65%
=======================================
Files 7 7
Lines 684 684
=======================================
Hits 538 538
Misses 146 146
Continue to review full report at Codecov.
|
|
Ah, yes, excellent! Could you please also bump the minimum Rust version in |
Since rust-lang/rust#44109 has landed, remove the hackery around non-exhaustive matching and use the attribute #[non_exhaustive] instead. Additionally, bump the min Rust version to [1.40.0](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1400-2019-12-19)
|
@jonhoo Done - all green now! |
jonhoo
approved these changes
Jan 30, 2020
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust#44109 has landed, remove the hackery around non-exhaustive matching
and use the attribute #[non_exhaustive] instead.