Implement From<String> for QuotaResourceName #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this doesn't seem quite right — it means there's no way to avoid turning it into an owned string. Wouldn't it be better to |
Yup.. that makes better sense. I knew this was "fishy", just wasn't sure how to easily fix it. |
urkle
force-pushed
the
fix-quota-resource-name-from
branch
from
9fc59c1
to
cc5944d
Compare
urkle
changed the title
|
@jonhoo updated |
- otherwise in common use-cases one cannot convert a String easily into a QuotaResourceName
urkle
force-pushed
the
fix-quota-resource-name-from
branch
from
cc5944d
to
245a6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using the quota feature in my application (finally) I noticed that I was running into life-time specifier issues trying to convert my input String into a QuotaResourceLimit through the Into argument.
I had to resort to re-implementing my own match line to convert into an Owned QuotaResourceName.
This PR adds an implementation of From for QuotaResourceName<'_> so strings can be utilized as well as &str.
This change is