Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI #293

Merged
merged 4 commits into from
Aug 18, 2024

Merge remote-tracking branch 'ci/main' into bump-ci

95cdec1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Bump CI #293

Merge remote-tracking branch 'ci/main' into bump-ci
95cdec1
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Aug 18, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (34)

src/client.rs|85 col 18| warning: this manual char comparison can be written more succinctly
--> src/client.rs:85:18
|
85 | .matches(|c| c == '\n' || c == '\r')
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of char: ['\n', '\r']
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: #[warn(clippy::manual_pattern_char_comparison)] on by default
src/client.rs|248 col 34| warning: the borrowed expression implements the required traits
--> src/client.rs:248:34
|
248 | self.session.run_command(&format!(
| _________________________^
249 | | "APPEND "{}" ({}){} {{{}}}",
250 | | self.mailbox,
251 | | flagstr,
252 | | datestr,
253 | | self.content.len()
254 | | ))?;
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: #[warn(clippy::needless_borrows_for_generic_args)] on by default
help: change this to
|
248 ~ self.session.run_command(format!(
249 + "APPEND "{}" ({}){} {{{}}}",
250 + self.mailbox,
251 + flagstr,
252 + datestr,
253 + self.content.len()
254 ~ ))?;
|
src/client.rs|560 col 18| warning: the borrowed expression implements the required traits
--> src/client.rs:560:18
|
560 | self.run(&format!(
| _________^
561 | | "SELECT {}",
562 | | validate_str("SELECT", "mailbox", mailbox_name.as_ref())?
563 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
560 ~ self.run(format!(
561 + "SELECT {}",
562 + validate_str("SELECT", "mailbox", mailbox_name.as_ref())?
563 ~ ))
|
src/client.rs|572 col 18| warning: the borrowed expression implements the required traits
--> src/client.rs:572:18
|
572 | self.run(&format!(
| _________^
573 | | "EXAMINE {}",
574 | | validate_str("EXAMINE", "mailbox", mailbox_name.as_ref())?
575 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
572 ~ self.run(format!(
573 + "EXAMINE {}",
574 + validate_str("EXAMINE", "mailbox", mailbox_name.as_ref())?
575 ~ ))
|
src/client.rs|646 col 48| warning: the borrowed expression implements the required traits
--> src/client.rs:646:48
|
646 | self.run_command_and_read_response(&format!(
| ___________________________________^
647 | | "FETCH {} {}",
648 | | validate_sequence_set(synopsis, "seq", sequence_set.as_ref())?,
649 | | validate_str_noquote(synopsis, "query", query.as_ref())?
650 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
646 ~ self.run_command_and_read_response(format!(
647 + "FETCH {} {}",
648 + validate_sequence_set(synopsis, "seq", sequence_set.as_ref())?,
649 + validate_str_noquote(synopsis, "query", query.as_ref())?
650 ~ ))
|
src/client.rs|666 col 48| warning: the borrowed expression implements the required traits
--> src/client.rs:666:48
|
666 | self.run_command_and_read_response(&format!(
| ___________________________________^
667 | | "UID FETCH {} {}",
668 | | validate_sequence_set(synopsis, "seq", uid_set.as_ref())?,
669 | | validate_str_noquote(synopsis, "query", query.as_ref())?
670 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
666 ~ self.run_command_and_read_response(format!(
667 + "UID FETCH {} {}",
668 + validate_sequence_set(synopsis, "seq", uid_set.as_ref())?,
669 + validate_str_noquote(synopsis, "query", query.as_ref())?
670 ~ ))
|
src/client.rs|720 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:720:39
|
720 | self.run_command_and_check_ok(&format!(
| ______________________________^
721 | | "CREATE {}",
722 | | validate_str("CREATE", "mailbox", mailbox_name.as_ref())?
723 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
720 ~ self.run_command_and_check_ok(format!(
721 + "CREATE {}",
722 + validate_str("CREATE", "mailbox", mailbox_name.as_ref())?
723 ~ ))
|
src/client.rs|746 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:746:39
|
746 | self.run_command_and_check_ok(&format!(
| ______________________________^
747 | | "DELETE {}",
748 | | validate_str("DELETE", "mailbox", mailbox_name.as_ref())?
749 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
746 ~ self.run_command_and_check_ok(format!(
747 + "DELETE {}",
748 + validate_str("DELETE", "mailbox", mailbox_name.as_ref())?
749 ~ ))
|
src/client.rs|778 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:778:39
|
778 | self.run_command_and_check_ok(&format!(
| ______________________________^
779 | | "RENAME {} {}",
780 | | quote!(from.as_ref()),
781 | | quote!(to.as_ref())
782 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
778 ~ self.run_command_and_check_ok(format!(
779 + "RENAME {} {}",
780 + quote!(from.as_ref()),
781 + quote!(to.as_ref())
782 ~ ))
|
src/client.rs|794 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:794:39
|
794 | self.run_command_and_check_ok(&format!("SUBSCRIBE {}", quote!(mailbox.as_ref())))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: format!("SUBSCRIBE {}", quote!(mailbox.as_ref()))
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
src/client.rs|802 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:802:39
|
802 | self.run_command_and_check_ok(&format!("UNSUBSCRIBE {}", quote!(mailbox.as_ref())))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: format!("UNSUBSCRIBE {}", quote!(mailbox.as_ref()))
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
src/client.rs|845 col 26| warning: the borrowed expression implements the required traits
--> src/client.rs:845:26
|
845 | self.run_command(&format!("UID EXPUNGE {}", uid_set.as_ref()))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: format!("UID EXPUNGE {}", uid_set.as_ref())
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
src/client.rs|932 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:932:44
|
932 | self.run_command_and_read_response(&format!(
| ___________________________________^
933 | | "STORE {} {}",
934 | | sequence_set.as_ref(),
935 | | query.as_ref()
936 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
932 ~ self.run_command_and_read_response(format!(
933 + "STORE {} {}",
934 + sequence_set.as_ref(),
935 + query.as_ref()
936 ~ ))
|
src/client.rs|947 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:947:44
|
947 | self.run_command_and_read_response(&format!(
| ___________________________________^
948 | | "UID STORE {} {}",
949 | | uid_set.as_ref(),
950 | | query.as_ref()
951 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
947 ~ self.run_command_and_read_response(format!(
948 + "UID STORE {} {}",
949 + uid_set.as_ref(),
950 + query.as_ref()
951 ~ ))
|
src/client.rs|967 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:967:39
|
967 | self.run_command_and_check_ok(&format!(
| ______________________________^
968 | | "COPY {} {}",
969 | | sequence_set.as_ref(),
970 | | mailbox_name.as_ref()
971 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
967 ~ self.run_command_and_check_ok(format!(
968 + "COPY {} {}",
969 + sequence_set.as_ref(),
970 + mailbox_name.as_ref()
971 ~ ))
|
src/client.rs|981 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:981:39
|
981 | self.run_command_and_check_ok(&format!(
| ______________________________^
982 | | "UID COPY {} {}",
983 | | uid_set.as_ref(),
984 | | mailbox_name.as_ref()
985 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
981 ~ self.run_command_and_check_ok(format!(
982 + "UID COPY {} {}",
983 + uid_set.as_ref(),
984 + mailbox_name.as_ref()
985 ~ ))
|
src/client.rs|1023 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:1023:39
|
1023 | self.run_command_and_check_ok(&format!(
| ______________________________^
1024 | | "MOVE {} {}",
1025 | | sequence_set.as_ref(),
1026 | | validate_str("MOVE", "mailbox", mailbox_name.as_ref())?
1027 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1023 ~ self.run_command_and_check_ok(format!(
1024 + "MOVE {} {}",
1025 + sequence_set.as_ref(),
1026 + validate_str("MOVE", "mailbox", mailbox_name.as_ref())?
1027 ~ ))
|
src/client.rs|1039 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:1039:39
|
1039 | self.run_command_and_check_ok(&format!(
| ______________________________^
1040 | | "UID MOVE {} {}",
1041 | | uid_set.as_ref(),
1042 | | validate_str("UID MOVE", "mailbox", mailbox_name.as_ref())?
1043 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1039 ~ self.run_command_and_check_ok(format!(
1040 + "UID MOVE {} {}",
1041 + uid_set.as_ref(),
1042 + validate_str("UID MOVE", "mailbox", mailbox_name.as_ref())?
1043 ~ ))
|
src/client.rs|1082 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1082:44
|
1082 | self.run_command_and_read_response(&format!(
| ___________________________________^
1083 | | "LIST {} {}",
1084 | | quote!(reference_name.unwrap_or("")),
1085 | | mailbox_pattern.unwrap_or("""")
1086 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1082 ~ self.run_command_and_read_response(format!(
1083 + "LIST {} {}",
1084 + quote!(reference_name.unwrap_or("")),
1085 + mailbox_pattern.unwrap_or("""")
1086 ~ ))
|
src/client.rs|1110 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1110:44
|
1110 | self.run_command_and_read_response(&format!(
| ___________________________________^
1111 | | "LSUB {} {}",
1112 | | quote!(reference_name.unwrap_or("")),
1113 | | mailbox_pattern.unwrap_or("")
1114 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1110 ~ self.run_command_and_read_response(format!(
1111 + "LSUB {} {}",
1112 + quote!(reference_name.unwrap_or("")),
1113 + mailbox_pattern.unwrap_or("")
1114 ~ ))
|
src/client.rs|1159 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1159:44
|
1159 | self.run_command_and_read_response(&format!(
| ___________________________________^
1160 | | "STATUS {} {}",
1161 | | validate_str("STATUS", "mailbox", mailbox_name)?,
1162 | | data_items.as_ref()
1163 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1159 ~ self.run_command_and_read_response(format!(
1160 + "STATUS {} {}",
1161 + validate_str("STATUS", "mailbox", mailbox_name)?,
1162 + data_items.as_ref()
1163 ~ ))
|
src/client.rs|1266 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1266:44
|
1266 | self.run_command_and_read_response(&format!("SEARCH {}", query.as_ref()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: format!("SEARCH {}", query.as_ref())
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
src/client.rs|1274 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1274:44
|
1274 | self.run_command_and_read_response(&format!("UID SEARCH {}", query.as_ref()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: format!("UID SEARCH {}", query.as_ref())
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
src/client.rs|1289 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1289:44
|
1289 | self.run_command_and_read_response(&format!(
| ___________________________________^
1290 | | "SORT {} {} {}",
1291 | | extensions::sort::SortCriteria(criteria),
1292 | | charset,
1293 | | query.as_ref()
1294 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1289 ~ self.run_command_and_read_response(format!(
1290 + "SORT {} {} {}",
1291 + extensions::sort::SortCriteria(criteria),
1292 + charset,
1293 + query.as_ref()
1294 ~ ))
|
src/client.rs|1307 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1307:44
|
1307 | self.run_command_and_read_response(&format!(
| ___________________________________^
1308 | | "UID SORT {} {} {}",
1309 | | extensions::sort::SortCriteria(criteria),
1310 | | charset,
1311 | | query.as_ref()
1312 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1307 ~ self.run_command_and_read_response(format!(
1308 + "UID SORT {} {} {}",
1309 + extensions::sort::SortCriteria(criteria),
1310 + charset,
1311 + query.as_ref()
1312 ~ ))
|
src/client.rs|1336 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:1336:39
|
1336 | self.run_command_and_check_ok(&format!(
| ______________________________^
1337 | | "SETACL {} {} {}{}",
1338 | | validate_str("SETACL", "mailbox", mailbox_name.as_ref())?,
1339 | | validate_str("SETACL", "identifier", identifier.as_ref())?,
1340 | | mod_str,
1341 | | rights,
1342 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1336 ~ self.run_command_and_check_ok(format!(
1337 + "SETACL {} {} {}{}",
1338 + validate_str("SETACL", "mailbox", mailbox_name.as_ref())?,
1339 + validate_str("SETACL", "identifier", identifier.as_ref())?,
1340 + mod_str,
1341 + rights,
1342 ~ ))
|
src/client.rs|1357 col 39| warning: the borrowed expression implements the required traits
--> src/client.rs:1357:39
|
1357 | self.run_command_and_check_ok(&format!(
| ______________________________^
1358 | | "DELETEACL {} {}",
1359 | | validate_str("DELETEACL", "mailbox", mailbox_name.as_ref())?,
1360 | | validate_str("DELETEACL", "identifier", identifier.as_ref())?,
1361 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1357 ~ self.run_command_and_check_ok(format!(
1358 + "DELETEACL {} {}",
1359 + validate_str("DELETEACL", "mailbox", mailbox_name.as_ref())?,
1360 + validate_str("DELETEACL", "identifier", identifier.as_ref())?,
1361 ~ ))
|
src/client.rs|1372 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1372:44
|
1372 | self.run_command_and_read_response(&format!(
| ___________________________________^
1373 | | "GETACL {}",
1374 | | validate_str("GETACL", "mailbox", mailbox_name.as_ref())?
1375 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1372 ~ self.run_command_and_read_response(format!(
1373 + "GETACL {}",
1374 + validate_str("GETACL", "mailbox", mailbox_name.as_ref())?
1375 ~ ))
|
src/client.rs|1392 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1392:44
|
1392 | self.run_command_and_read_response(&format!(
| ___________________________________^
1393 | | "LISTRIGHTS {} {}",
1394 | | validate_str("LISTRIGHTS", "mailbox", mailbox_name.as_ref())?,
1395 | | validate_str("LISTRIGHTS", "identifier", identifier.as_ref())?
1396 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1392 ~ self.run_command_and_read_response(format!(
1393 + "LISTRIGHTS {} {}",
1394 + validate_str("LISTRIGHTS", "mailbox", mailbox_name.as_ref())?,
1395 + validate_str("LISTRIGHTS", "identifier", identifier.as_ref())?
1396 ~ ))
|
src/client.rs|1407 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1407:44
|
1407 | self.run_command_and_read_response(&format!(
| ___________________________________^
1408 | | "MYRIGHTS {}",
1409 | | validate_str("MYRIGHTS", "mailbox", mailbox_name.as_ref())?,
1410 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1407 ~ self.run_command_and_read_response(format!(
1408 + "MYRIGHTS {}",
1409 + validate_str("MYRIGHTS", "mailbox", mailbox_name.as_ref())?,
1410 ~ ))
|
src/client.rs|1426 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1426:44
|
1426 | self.run_command_and_read_response(&format!(
| ___________________________________^
1427 | | "SETQUOTA {} ({})",
1428 | | validate_str("SETQUOTA", "quota_root", quota_root.as_ref())?,
1429 | | limits,
1430 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1426 ~ self.run_command_and_read_response(format!(
1427 + "SETQUOTA {} ({})",
1428 + validate_str("SETQUOTA", "quota_root", quota_root.as_ref())?,
1429 + limits,
1430 ~ ))
|
src/client.rs|1438 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1438:44
|
1438 | self.run_command_and_read_response(&format!(
| ___________________________________^
1439 | | "GETQUOTA {}",
1440 | | validate_str("GETQUOTA", "quota_root", quota_root.as_ref())?
1441 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1438 ~ self.run_command_and_read_response(format!(
1439 + "GETQUOTA {}",
1440 + validate_str("GETQUOTA", "quota_root", quota_root.as_ref())?
1441 ~ ))
|
src/client.rs|1449 col 44| warning: the borrowed expression implements the required traits
--> src/client.rs:1449:44
|
1449 | self.run_command_and_read_response(&format!(
| ___________________________________^
1450 | | "GETQUOTAROOT {}",
1451 | | validate_str("GETQUOTAROOT", "mailbox", mailbox_name.as_ref())?
1452 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1449 ~ self.run_command_and_read_response(format!(
1450 + "GETQUOTAROOT {}",
1451 + validate_str("GETQUOTAROOT", "mailbox", mailbox_name.as_ref())?
1452 ~ ))
|
src/extensions/list_status.rs|148 col 44| warning: the borrowed expression implements the required traits
--> src/extensions/list_status.rs:148:44
|
148 | self.run_command_and_read_response(&format!(
| ___________________________________^
149 | | "LIST {} {} RETURN (STATUS {})",
150 | | &reference,
151 | | mailbox_pattern.unwrap_or(""""),
152 | | data_items
153 | | ))
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
148 ~ self.run_command_and_read_response(format!(
149 + "LIST {} {} RETURN (STATUS {})",
150 + &reference,
151 + mailbox_pattern.unwrap_or(""""),
152 + data_items
153 ~ ))
|