Skip to content

Commit

Permalink
chore: use workspace: protocol for workspace dependencies
Browse files Browse the repository at this point in the history 
Closes patternfly#10547

Signed-off-by: Jon Koops <[email protected]>
  • Loading branch information
@jonkoops
jonkoops committed Jun 7, 2024
1 parent d49c3b5 commit 007f93b
Show file tree
Hide file tree
Showing 12 changed files with 11,341 additions and 166 deletions.
4 changes: 0 additions & 4 deletions GETTING-STARTED.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,3 @@ PatternFly React has 3 linters you can run all at once using `yarn lint:all`. Th
### ESLint

ESLint is run on .js, .jsx, .ts, and .tsx files. It uses the [@typescript-eslint](https://github.com/typescript-eslint/typescript-eslint) parser with custom config added over the years. We write some of our own ESLint rules in `eslint-plugin-patternfly-react`. You can run this linter with `yarn lint:ts` or on specific files with `yarn lint <path>`.

### Version lint

The `@patternfly` version linter is run on all `package.json` files to ensure that versions of all `@patternfly/*` packages match. This is done to prevent mismatching versions of essential PatternFly packages from accidentally being published. You can run this linter with `yarn lint:versions`.
6 changes: 2 additions & 4 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,9 @@
"clean:exports": "lerna run clean:exports --parallel --stream",
"generate": "yarn plop",
"lint": "eslint --ext js,jsx,ts,tsx --cache --cache-strategy content",
"lint:all": "yarn lint:md && yarn lint:versions && yarn lint:ts",
"lint:all": "yarn lint:md && yarn lint:ts",
"lint:md": "yarn eslint packages --ext md --no-eslintrc --config .eslintrc-md.json --cache --cache-strategy content",
"lint:ts": "yarn lint packages/*/src",
"lint:versions": "node scripts/verifyPatternflyVersions.js",
"lint:tests": "yarn lint packages/*/src/components/*/__tests__/*.test.*",
"prepare": "ts-patch install -s",
"serve:docs": "yarn workspace @patternfly/react-docs serve",
Expand All @@ -113,8 +112,7 @@
},
"lint-staged": {
"*.md": "yarn lint:md --fix",
"*.{js,jsx,ts,tsx}": "yarn lint --fix",
"*.json": "yarn lint:versions --fix"
"*.{js,jsx,ts,tsx}": "yarn lint --fix"
},
"workspaces": {
"packages": [
Expand Down
4 changes: 2 additions & 2 deletions packages/react-charts/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
},
"homepage": "https://github.com/patternfly/patternfly-react#readme",
"dependencies": {
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"hoist-non-react-statics": "^3.3.0",
"lodash": "^4.17.21",
"tslib": "^2.6.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-code-editor/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
},
"dependencies": {
"@monaco-editor/react": "^4.6.0",
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"react-dropzone": "14.2.3",
"tslib": "^2.6.2"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/react-core/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
"clean:exports": "node scripts/cleanDistExports.js"
},
"dependencies": {
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"focus-trap": "7.5.4",
"react-dropzone": "^14.2.3",
"tslib": "^2.6.2"
Expand Down
18 changes: 9 additions & 9 deletions packages/react-docs/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
},
"dependencies": {
"@patternfly/patternfly": "5.4.0-prerelease.3",
"@patternfly/react-charts": "^7.4.0-prerelease.11",
"@patternfly/react-code-editor": "^5.4.0-prerelease.17",
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-drag-drop": "^5.4.0-prerelease.16",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-table": "^5.4.0-prerelease.16",
"@patternfly/react-templates": "^1.1.0-prerelease.15",
"@patternfly/react-tokens": "^5.4.0-prerelease.5"
"@patternfly/react-charts": "workspace:^",
"@patternfly/react-code-editor": "workspace:^",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-drag-drop": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-table": "workspace:^",
"@patternfly/react-templates": "workspace:^",
"@patternfly/react-tokens": "workspace:^"
},
"devDependencies": {
"@patternfly/documentation-framework": "^5.15.7",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-drag-drop/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
"@dnd-kit/core": "^6.1.0",
"@dnd-kit/modifiers": "^6.0.1",
"@dnd-kit/sortable": "^7.0.2",
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"memoize-one": "^5.1.0",
"resize-observer-polyfill": "^1.5.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-integration/demo-app-ts/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"preview": "vite preview --port 3000"
},
"dependencies": {
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-core": "workspace:^",
"react": "^18",
"react-dom": "^18",
"react-router": "^5.3.4",
Expand Down
8 changes: 4 additions & 4 deletions packages/react-table/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"subpaths": "node ../../scripts/exportSubpaths.js --config subpaths.config.json"
},
"dependencies": {
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"lodash": "^4.17.21",
"tslib": "^2.6.2"
},
Expand Down
8 changes: 4 additions & 4 deletions packages/react-templates/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"subpaths": "node ../../scripts/exportSubpaths.js --config subpaths.config.json"
},
"dependencies": {
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"tslib": "^2.6.2"
},
"peerDependencies": {
Expand Down
75 changes: 0 additions & 75 deletions scripts/verifyPatternflyVersions.js
View file

This file was deleted.

Loading

0 comments on commit 007f93b

Please sign in to comment.