make "spring test" support any number of arguments #102
Conversation
|
Hold tight - I'm working on tests for this ... |
|
Weird, Ruby 2.0 doesn't like my use of |
|
Ah, |
|
guard/guard-minitest#57 adds support for spring based off this pull request. |
| ARGV.replace args | ||
| path = File.expand_path(args.first) | ||
| if args.empty? | ||
| args = [ 'test' ] |
There was a problem hiding this comment.
please use ['test'] to be consistent with the existing code.
|
If you're here at RubyManor maybe we could meet for a quick chat about this? I'll try to split the input validation commit out into a different pull request so that we can get the other (non-contentious) commits merged at least. |
|
OK, the contentious change is no longer part of this pull request. I also rebased against latest |
| @@ -148,7 +148,7 @@ def spring_test_command | |||
|
|
|||
| teardown do | |||
| app_run "#{spring} stop" | |||
| File.write(@test, @test_contents) | |||
| File.write(@test, @test_contents) unless @test.empty? | |||
There was a problem hiding this comment.
It's a remnant from the test you asked to be dropped. I guess we can ditch it now, although it still makes sense for if we wanted to re-introduce a similar test in the future.
|
Sorry, I was at Ruby Manor but I didn't see your message |
|
I'll tidy up this stuff soon and re-push. |
"spring test" needs to accept multiple arguments if guard-minitest is to ever have a chance of supporting spring.
With no arguments, it now defaults to running all test-unit tests it can find, i.e. files matching test/**/*_test.rb. This is more useful and arguably more intuitive too. We need to remove test/performance/browsing_test.rb from the Rails app being tested, otherwise "spring test" attempts to run this when it iterates over test/**/*_test.rb, causing a failure due to ruby-prof not being installed. Signed-off-by: Adam Spiers <[email protected]>
|
OK, another attempt... |
make "spring test" support any number of arguments
This obsoletes #101.
spring testneeds to accept multiple arguments if guard-minitest is to ever have a chance of supporting spring. Specs are automatically pruned from the command-line with a warning, since loading specs will stop the unit tests from running.It's also useful for it to support zero arguments, in which case it does the sensible thing and defaults to running all unit tests. Additionally, this is consistent with the behaviour of
spring rspec.