Add fullscreen bypass support #808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronNemo
reviewed
Mar 3, 2021
| @@ -50,10 +51,18 @@ sigdisable(int signo) | |||
| disable = 1; | |||
| } | |||
|
|
|||
| /* Signal handler for disabling the fullscreen detector signal */ | |||
There was a problem hiding this comment.
Redshift is in sore need of a control interface other than signals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for automatically disabling redshift when a fullscreen application is detected, solving issue #548.
There is a possibility to disable this function from command line with the option "-f 0".
Differing from #407, this implements the function in the redshift daemon.
It does not use the EWMH because it is not reliable enough (confirmed poor compatibility with i3).
No implementation has been made for Windows yet, but the code should still compile.
EDIT:
Also, there is a SIGUSR2 and a checkbox in redshift-gtk to disable this function at any time.
EDIT:
Multi-monitor support is a bit tricky and must be decided how it should work before it is developed.
I think it must check if the focused window is fullscreen in its display and disable redshift for all displays, or make a per-display control, but I don't know if this is possible.