Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent division by zero error by setting null as fallback value for force16to9 #3

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

batabana
Copy link

The force16to9 property is boolean, but if it was set to false on a video I kept getting a "Division by zero" error from Fusion. I think this is caused by the line finalRatio = ${Jonnitto.PrettyEmbedHelper.paddingTop(this.ratio || this.force16to9)} in Component/Video/Video.fusion as the paddingTophelper expects float|integer|string (and defaults to null) but no boolean value.

@jonnitto jonnitto merged commit 5bde7b9 into jonnitto:master Sep 27, 2022
@jonnitto jonnitto added the bug Something isn't working label Sep 27, 2022
@jonnitto
Copy link
Owner

Hey @batabana

Thanks for fixing this! I already released this: 2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants