Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async functions + Tests for arraybuffer, dataview and async function #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pjbatista
Copy link

@pjbatista pjbatista commented Sep 26, 2018

  • Added support for the ES2017 AsyncFunction type;
  • Added tests for ArrayBuffer, DataView and async functions.

@tunnckoCore
Copy link
Contributor

tunnckoCore commented Sep 26, 2018

I feel there is too much noise to that PR, but @jonschlinkert is the master here :D
I'm basically doing the same thing :D most of the time cuz I'm lazy to do separate PRs for small changes.

And I'm mentioning Jon, because I know what's the feeling to mostly always miss a PR, because of the notification noise. ;d I definitely think to add some GitHub bot to help with that.

@pjbatista
Copy link
Author

I mean, I should've added a comment to the commit, but I also cleanup up a few eslint warnings. And I only saw your PR after I already had submitted mine, because asyncs were my main goal too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants