Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddc_write incorrect for values < 0x1ff #1

Open
jakealbert opened this issue Jul 23, 2014 · 0 comments
Open

ddc_write incorrect for values < 0x1ff #1

jakealbert opened this issue Jul 23, 2014 · 0 comments

Comments

@jakealbert
Copy link

in ddc/ddc.c: ddc_write, the new value is set with:
data[5] = (_p_write).new_value;
data[4] = 0x1;
which is incorrect for values < 0x1ff. It should be:
data[4] = ((_p_write).new_value) >> 8;
data[5] = ((*p_write).new_value & 255);

kfix added a commit to kfix/ddcctl that referenced this issue Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant