Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pac4j: logout doesn't work with MongoSessionStore #759

Closed
silentcharacter opened this issue May 6, 2017 · 2 comments
Closed

pac4j: logout doesn't work with MongoSessionStore #759

silentcharacter opened this issue May 6, 2017 · 2 comments
Milestone

Comments

@silentcharacter
Copy link

Hi Edgar!
I've tried using session(MongoSessionStore.class) and noticed that logout doesn't work.
Found out that session.unset() is not applied in mongo session collection. During next request unset parameter exists again.

@jknack
Copy link
Member

jknack commented May 6, 2017

Think there is a bug here with unset but for logout you should use destroy

@silentcharacter
Copy link
Author

@jknack I'm using jooby-pac4j\1.1.0\jooby-pac4j-1.1.0.jar!\org\jooby\internal\pac4j\AuthLogout.class
...
Optional profileId = ((Session)ifSession.get()).unset(Auth.ID).toOptional();
...

@jknack jknack changed the title session.unset() doesn't work with MongoSessionStore pac4j: logout doesn't work with MongoSessionStore May 21, 2017
@jknack jknack added this to the 1.1.2 milestone May 21, 2017
@jknack jknack closed this as completed in 25ae793 May 22, 2017
jknack added a commit that referenced this issue May 22, 2017
pac4j: logout doesn't work with MongoSessionStore fix #759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants