Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Joomla Dialog (popup) script #99

Merged
merged 19 commits into from
Sep 5, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Apr 2, 2023

Docs for PR joomla/joomla-cms#40150
Can be merged only after that PR is merged.

@HLeithner
Copy link
Member

Maybe we should create a new section for webcomponents?

@Fedik
Copy link
Member Author

Fedik commented Apr 10, 2023

I not sure, I think maybe better keep it "by function" instead of "by type".
In future we can have some info for core.js, validation.js, maybe some other js.

I want to keep it simple, in the end it still javascript :)
The section can be added in separated PR, if need.

@Fedik
Copy link
Member Author

Fedik commented Apr 10, 2023

I have moved "new section" to #108

@Fedik Fedik changed the title New JavaScript section, and docs for Joomla Dialog (popup) script Docs for Joomla Dialog (popup) script Apr 10, 2023
@Fedik
Copy link
Member Author

Fedik commented Sep 5, 2023

So the links does not works, because the build use /versioned_docs/version-4.3 for build not /docs,
Cannot find where it is configured.

@HLeithner HLeithner merged commit 474b55c into joomla:5.0 Sep 5, 2023
@Fedik
Copy link
Member Author

Fedik commented Sep 5, 2023

Hm, if we use absolute, then it should be without .md or it will be just broken, no?

@Fedik Fedik deleted the jdialog branch September 5, 2023 20:03
@HLeithner
Copy link
Member

yes you are right .md is wrong...

@m4dprodlev
Copy link

useScript('joomla.dialog'); ?>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants