[4.0] Filtered by - accessibility #27741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous pull request I added code which adds a caption to every table AND indicates how the table is sorted. To improve this further we should also include how the table is filtered. This DRAFT pr which I hope the javascript gurus can help with adds the filtered information. I have only enabled this for the table of contacts at this time while in draft Currently the output is like this <caption id="captionTable" class="sr-only"> Table of Contacts <span id="orderedBy">Sorted by:Title - descending</span> <span id="filteredBy">Filtered by:Public3</span> </caption> As you can see the filtered by is displaying just the selected value of the selected filters, which is kind of ok when its text but is meaningless when it is a number. Ideally it would say Filtered by: Access level = Public, Max Levels =3
joomla-cms-bot
added
Language Change
brianteeman
added
a11y
joomla-cms-bot
added
Language Change
|
that makes sense .-) |
|
Maybe someone can convince the accessibility team to test this |
|
Christiane helped Stefan. He knows what do do - still waiting for results (1 week). |
|
Closed - let the accessibility team fix it |
wilsonge
added a commit
to wilsonge/joomla-cms
that referenced
this pull request
May 8, 2020
Extend joomla#27741 to fully implement the prototype of filtering. This can be rolled out to all components in a future PR. This is mainly to help people with the javascript implementation
|
Javascript here for you hopefully. It's enough to work - although as the labels seem weird right now the text could be improved. But hopefully that's enough for someone to run with |
|
Thanks. Will check it out over the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous pull request I added code which adds a caption to every table AND indicates how the table is sorted. This is only visible to screen readers
To improve this further we should also include how the table is filtered.
This DRAFT pr which I hope the javascript gurus can help with adds the filtered information.
I have only enabled this for the table of contacts at this time while in draft
Currently the output is like this
As you can see the filtered by is displaying just the selected value of the selected filters, which is kind of ok when its text but is meaningless when it is a number.
Ideally it would say
Filtered by: Access level = Public, Max Levels =3(as this is javascript it will require either
npm iornode build.js --compile-jsto test it)