[4.0] Filtered item information [a11y] #28997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
Language Change
wilsonge
approved these changes
May 8, 2020
|
Add a space after |
output is now Table of Contacts, Sorted by: Title - descending, Filtered by: Status: Published
…ter value Table of Contacts, Sorted by: Title - descending, Filtered by: Status - Published
C-Lodder
reviewed
May 9, 2020
| captionContent = `${element.labels[0].textContent} - ${element.options[element.selectedIndex].text}`; | ||
| } | ||
|
|
||
| document.getElementById('filteredBy').textContent += captionContent; |
There was a problem hiding this comment.
You can replace document.getElementById('filteredBy') with filteredByCaption, as you've defined it as a variable above
C-Lodder
reviewed
May 9, 2020
|
|
||
| if (element.multiple === true) { | ||
| const selectedOptions = element.querySelectorAll('option:checked'); | ||
| const selectedTextValues = Array.from(selectedOptions).map((el) => el.text); |
There was a problem hiding this comment.
You can't use Array.from(...) as it's not support in IE11. Use [].slice.call(selectedOptions)
There was a problem hiding this comment.
are we supporting ie11 or not
|
Thanks! |
|
Right I guess I need to do all the other components now |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
May 9, 2020
Completes the work from joomla#28997 Testing is the same
wilsonge
pushed a commit
that referenced
this pull request
May 9, 2020
[4.0] Filtered Item Information work continued from #28997
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Table of Contacts, Sorted by: Title - descending, Filtered by: Status - Published
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
[4.0] Filtered Item Information work continued from joomla#28997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous pull request I added code which adds a caption to every table AND indicates how the table is sorted. This is only visible to screen readers. This is very important for accessibility so a user will now all the relevant information for the table being displayed
To improve this further it should also include how the table is filtered.
I have only enabled this for the table of contacts at this time. If/when approved I will do the same for the other tables.
This PR will also allow the designers to add a visual display of the filters which people like @angieradtke have suggested
I also had to use real label strings for the filters instead of re-using the string from the option. I should have done this before but ...
Thanks to @wilsonge for fixing the js
(as this is javascript it will require either
npm iornode build.js --compile-jsto test it)Testing is really simple
Once the pr has been applied and the js compiled go to the list of all contacts in the admin
If you view source you will see
Play around adding filters and it will change as below
A screen reader will see the text as
Table of Contacts, Sorted by: Title - descending, Filtered by: Status: Published