normalized_when_valid: true seems broken if there are two phone attributes

[dlikhten]

definition:

validates_plausible_phone :phone, if: :phone?, message: :bad_format
validates_plausible_phone :fax, if: :fax?, message: :bad_format
phony_normalize :phone, normalize_when_valid: true
phony_normalize :fax, normalize_when_valid: true

spec

  it "an invalid phone doesn't get reformatted" do
    practice = Thing.new(phone: '212-555-55')
    expect(practice.phone).to eq('212-555-55')
    expect(practice).to_not be_valid
    expect(practice.phone).to eq('212-555-55')
  end

This will fail. HOWEVER the same test on fax will work. It seems that the phone is set to the value of fax because fax is defined second. This is only the case when noramlize_when_valid is set.

[joost]

Fix with pull request welcome.

…

On Tue, Jun 25, 2019, 23:00 dlikhten ***@***.***> wrote: definition: validates_plausible_phone :phone, if: :phone?, message: :bad_format validates_plausible_phone :fax, if: :fax?, message: :bad_format phony_normalize :phone, normalize_when_valid: true phony_normalize :fax, normalize_when_valid: true spec it "an invalid phone doesn't get reformatted" do practice = Thing.new(phone: '212-555-55') expect(practice.phone).to eq('212-555-55') expect(practice).to_not be_valid expect(practice.phone).to eq('212-555-55') end This will fail. HOWEVER the same test on fax will work. It seems that the phone is set to the value of fax because fax is defined second. This is only the case when noramlize_when_valid is set. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#195?email_source=notifications&email_token=AAAWKST3DDT2FP2PNIPCMKTP4KBQFA5CNFSM4H3MHIG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3UZ7UA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWKSUH4Q5KNELP7MYZF23P4KBQFANCNFSM4H3MHIGQ> .

[dlikhten]

Yaaaaaas! Alright! Thanks! Also bonus points if you make a .13 release! 😸

[joost]

Done

[dlikhten]

Thank you!!! :)