Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a default country code #137

Merged
merged 4 commits into from
Apr 19, 2016

Conversation

jerryclinesmith
Copy link
Contributor

Instead of always passing country code on each call, add support for it to be set once (probably in an Initializer):

PhonyRails.default_country_code = "US"

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.758% when pulling 6465ad6 on jerryclinesmith:default-country-code into cfb90f5 on joost:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ce7576c on jerryclinesmith:default-country-code into cfb90f5 on joost:master.

@joost
Copy link
Owner

joost commented Apr 19, 2016

@jerryclinesmith looks good! Can you add some info in the README?

@jerryclinesmith
Copy link
Contributor Author

Comments added.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 384bab0 on jerryclinesmith:default-country-code into cfb90f5 on joost:master.

@joost joost merged commit 337f886 into joost:master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants