support for ActiveModel::Model alternative to database-backed models only

[brandondees]

related to #143

PhonyRails can be added to ActiveModel::Model as well as ActiveRecord::Base to enable usage in models that are not db-backed. There is also a dependency on ActiveModel::Validations::Callbacks as the normalization currently depends on a before_validate callback.

I am using this version for my project and have extended the basic test coverage to #account for this usage variant. Please provide any relevant critique or feedback.

[coveralls]

Coverage increased (+0.0004%) to 99.796% when pulling 379cc03 on brandondees:activerecord-freedom into 17a310d on joost:master.

[brandondees]

I'll see if I can reproduce this build failure.

[brandondees]

I had accidentally removed one of the tested attribute names.

[coveralls]

Coverage increased (+0.0004%) to 99.796% when pulling e11cc3b on brandondees:activerecord-freedom into 17a310d on joost:master.

[joost]

Sorry for the late reply. I like this. However we don't need to include in AR::Base AND AR::Model right?

[sighmin]

@brandondees @joost This is awesome I use form objects when the validations for the endpoint are different for the persisted model itself.

Yeah I don't think you need to include it in AR::Base just AR:Model

Thanks @brandondees 🎉

[brandondees]

sorry, I didn't get notifications for your replies...

I didn't want to interfere with existing use cases / tests so I left the existing behavior alone, just extended it to work with plain models.

[sighmin]

@brandondees No worries :) As far as I can remember ActiveRecord::Model is included in ActiveRecord::Base.

Keep in mind you can use ActiveModel without ActiveRecord, so just check for the presence of ActiveModel constant and include it in there and we should golden 👍 @joost any changes before merge?

[joost]

Only remove the duplication. ActiveRecord::Base should not include but inherit from ::Model.

On 05 Jun 2016, at 08:40, Simon van Dyk [email protected] wrote:

@brandondees No worries :) As far as I can remember ActiveRecord::Model is included in ActiveRecord::Base.

Keep in mind you can use ActiveModel without ActiveRecord, so just check for the presence of ActiveModel constant and include it in there and we should golden 👍 @joost any changes before merge?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.