Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return country from phone number #169

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Conversation

aovertus
Copy link
Contributor

@aovertus aovertus commented Oct 6, 2017

Its confusing that country_code_from_number return a country_number

I would rather do
country_number_from_number => "32"
country_code_from_number => "BE"

But I don't want to break existing stuff.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.81% when pulling e7aadac on aovertus:country_from_number into 9b002ec on joost:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.81% when pulling e7aadac on aovertus:country_from_number into 9b002ec on joost:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.81% when pulling 24ceced on aovertus:country_from_number into 9b002ec on joost:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.81% when pulling 24ceced on aovertus:country_from_number into 9b002ec on joost:master.

@coveralls
Copy link

coveralls commented Oct 21, 2017

Coverage Status

Coverage increased (+0.001%) to 99.81% when pulling e3dd653 on aovertus:country_from_number into 9b002ec on joost:master.

fix syntax

fix review
@aovertus
Copy link
Contributor Author

Hey @joost thanks for this phony_rails gem.

Do you mind to give me some feedbacks ? We would like to update the gem with this fix

@joost
Copy link
Owner

joost commented Dec 21, 2017

Thanks for the pull request. What is the intention? It introduces a new method?

@aovertus
Copy link
Contributor Author

aovertus commented Jan 3, 2018

Hi @joost , yes its introducing a new method which allow developers to retrieve the country from the phone_number

PhonyRails.country_from_number('+32475000000') => 'BE'

@joost joost merged commit 0001539 into joost:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants