Ability to validate against the normalized input

[dimroc]

Useful in the scenario when you want to allow

#10 digits are extremely common in the US
555 555 5555

even though it would fail Phony.plausible?().

After normalizing for “US”, this would pass.
i.e. Phony.plausible?(PhonyRails.normalize_number)

Usage looks like:

validates_plausible_phone :phone_number, normalized_country_code: 'US'

[joost]

Seems nice addition but can't you just put the validation on the normalized version?

[dimroc]

That's what I had done at first but it allowed bad data in the phone_number because normalization would blank out the field which in turn would pass validation. And I still do want the field to allow_blank:

  phony_normalize :phone_number, as: :phone_number_normalized, :default_country_code => 'US'
  validates_plausible_phone :phone_number_normalized

Input "xxxx" as phone_number will pass validation, saving "xxxx" in phone_number and saving blank in phone_number_normalized. My PR prevents this.

This was also an issue for me here:

  phony_normalize :phone_number, :default_country_code => 'US'
  validates_plausible_phone :phone_number

[joost]

What if you add something like:

validates :phone_number, presence: true

So nil or blank is not allowed?!

[dimroc]

I either want a plausible phone number, or no phone number at all. Blank or a plausible phone number. I'm not sure how that line would help me.

[dimroc]

The crux of the issue is this: when normalizing fails, it blanks out the field, so allowing blank will allow entries that fail normalization.

[joost]

👍 merged will push new gem soon

[joost]

This now is in v0.7.3.

[dimroc]

Just updated the gem and it all worked great. Thanks.

On Thu, Oct 23, 2014 at 10:44 AM, Joost Hietbrink [email protected]
wrote:

This now is in v0.7.3.

—
Reply to this email directly or view it on GitHub
#64 (comment).