Add enforce_record_country option to phony_normalize method #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option defaults to true for conssistent behaviour. If you turn it off and the records phone number is prefixed by a plus sign the records country_code will not be added as the country number.
joost
pushed a commit
that referenced
this pull request
Jun 19, 2015
Add enforce_record_country option to phony_normalize method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option for the behaviour I described in #97.
If you turn the option off the
country_codeof the record will be passed to thePhonyRails.normalize_numberas thedefault_country_codeinstead of thecountry_code. In effect the country number won't be force added so the user can specify a number from a different country than the country_code indicates.I had to add a new model for the specs because I didn't see a non-hackish way to change the existing model.
Maybe the option name could be better, but that can easily be changed.