Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PyQt6 #1072

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Migrate to PyQt6 #1072

wants to merge 40 commits into from

Conversation

jopohl
Copy link
Owner

@jopohl jopohl commented Oct 26, 2023

This PR migrates URH to PyQt6 and adds support for recent Python versions.
This PR drops support for 32-bit Windows since PyQt6 wheels are not available for this platform.

@jopohl jopohl changed the title Migrate to PyQt6 Migrate to PyQt6 and upgrade Python CI versions Oct 27, 2023
@jopohl jopohl marked this pull request as ready for review October 27, 2023 14:30
@jopohl jopohl requested a review from andynoack October 27, 2023 14:34
@jopohl jopohl marked this pull request as draft October 27, 2023 14:41
@jopohl jopohl changed the title Migrate to PyQt6 and upgrade Python CI versions Migrate to PyQt6 Oct 27, 2023
@jopohl jopohl marked this pull request as ready for review October 27, 2023 15:10
@jopohl
Copy link
Owner Author

jopohl commented Oct 27, 2023

@andynoack wdyt? Would appreciate if you could test this branch since a bunch of changes were necessary. The CI passes and I tested manually but from experience your eyes still catch bugs. ;) Please note the Cython extensions need to be rebuilt.

@andynoack
Copy link
Collaborator

Works fine for me! I am not sure whether we should push it to master yet if it drops Win32 support. Can we make a win32 survey or something like that?

@jopohl
Copy link
Owner Author

jopohl commented Oct 28, 2023

I have similar concerns. Previous version was downloaded over 1k times for Windows 32 bit
image

Not sure, however, how many of those 32 bit downloads are accidental.

There is also QtPy which acts as an abstraction layer and allows end-users to choose themselves between PyQt5 / PyQt6 / PySide2 and Pyside6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants