Add support for building using bazel
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
reviewed
May 16, 2023
This code change adds support for building using `bazel` if the `--use-bazel` flag is set. It will be unset by default.
healthy-pod
force-pushed
the
bazel-gcassert
branch
from
da07055
to
b6647bb
Compare
yuzefovich
approved these changes
May 16, 2023
|
TFTQR! |
healthy-pod
pushed a commit
to healthy-pod/cockroach
that referenced
this pull request
Jun 8, 2023
This code change pulls changes from jordanlewis/gcassert#11 and jordanlewis/gcassert#12 to let gcassert use bazel to build if the `--use-bazel` flag is set. It now checks if inline directives passed by inspecting object files because the compiler output is missing some inline statements when invoked through `bazel`. Release note: None Epic: CRDB-8349 Closes cockroachdb#65485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change adds support for building using
bazelif the--use-bazelflag is set. It will be unset by default.