This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fix the inferred nullability when converting a nested parquet schema to arrow #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to arrow This allows the `parquet_read` example to correctly read the nested data attached to issue jorgecarleitao#1556 and also makes several test assertions match the comments above.
|
@ritchie46 or @sundy-li as the parquet expert, could you take a look at this PR? Or should I rather re-open this against pola-rs/nano-arrow? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
+ Coverage 83.06% 83.08% +0.02%
==========================================
Files 391 391
Lines 42889 42929 +40
==========================================
+ Hits 35626 35668 +42
+ Misses 7263 7261 -2
☔ View full report in Codecov by Sentry. |
@jhorstmann could you please do so? That would get the patched in polars as well. |
This was referenced Oct 9, 2023
jhorstmann
added a commit
to jhorstmann/polars
that referenced
this pull request
Oct 9, 2023
The `parquet_to_arrow_schema` function tries to set the `nullable` flag of
`Field` according to the parquet repetition levels. That flag is then used
via the `InitNested` `enum` to calculate the level at which data is valid.
In the following parquet message type, neither the list nor its elements
should be marked as `nullable`, the definition level for the `REPEATED`
group only indicates an empty list but not any nulls.
```
message eventlog {
REQUIRED group events (LIST) {
REPEATED group array {
REQUIRED BYTE_ARRAY event_name (STRING);
REQUIRED INT64 event_time (TIMESTAMP(MILLIS,true));
}
}
}
```
The nullability of fields was asserted in multiple tests, but those
assertions did not match the comments.
This is a port of jorgecarleitao/arrow2#1565 to the nano-arrow crate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
parquet_readexample to correctly read the nested data attached to issue #1556 and also makes several test assertions match the comments above.