-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python-ts-mode #2015
Conversation
How long have you been testing this? I don't use |
Just a couple of days. It seems to work fine but I can test it a bit more. |
Yeah lets test for a ~month, to be on the conservative side. |
Any issues @gmlarumbe ? |
Hi @gomar, I did not have much time to test it extensively. However it seems to work fine with both Emacs bundled I also added a symlink for the yasnippet snippets of |
I believe the correct way is to add .yas-parents and put |
Hi @gopar , The .yas-parents for I also changed the enabling of elpy for |
Merging. Not sure why the tests are failing there, but it should be unrelated |
PR Summary
elpy-mode
requires currentmajor-mode
be a derived mode ofpython-mode
. Emacs 29 bundlespython-mode
andpython-ts-mode
as derived modes ofpython-base-mode
. This PR allowselpy
to also be used withpython-ts-mode
.PR checklist