-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress on version next
#337
Comments
Would it be possible to rewrite styles in SCSS for v6? Happy to help with a PR if so 😄 |
Thanks for your offer @hassankhan. The styles are now in less though sass seems to be more popular lately. I'm ok with switching to sass, thanks beforehand! One other thing that I've been wanting to do for a long time is replace the png sprite with icons with an icon font or else SVG's. Is that something you could help with too? |
Hi! I'd checked the And yes, switching to icon fonts/SVGs would be great and should be totally doable. Is there a font-pack you have in mind? |
I haven't looked into what solutions there are out there to create an icon font, do you have a proposal? I think it would be nicest to have an icon font and not SVG's since it's so easy to style the colors using css buy maybe there are other pros/cons to choose one or the other. What are your thoughts in this regard? |
Personally, I'm a fan of Font Awesome, but I do realize people may have their own preferences. How I would go about solving that is by providing variables for the font icon path as well as for each individual icon: $icon-font-path: '';
$icon-open : ''; |
Yes, making the icons customizable is a good idea. I like Font Awesome too but we can't just use it since it doesn't contain all the icons we need, so we have to create an icon font our selves. I know there are tools to do this but I haven't yet looked into what it would take and what the options and limitations are. |
Didn't manage to run it yet, it shows: |
@josdejong I can suggest two things, not sure if they are included in this plan:
|
Thanks for giving it a try @epoberezkin . I'm not sure how I can reproduce your The general plan is simply to always stay up to date with the latest version of The editor now supports JSON Patch to synchronize contents (see example), which finally allows synchronization. Synchronizing navigation between two panels is an interesting idea, I haven't really thought about that option so far. |
Not sure what I've done wrong... It's all working now, sorry.
It could attempt parsing and sync as soon as it is valid. Anyway, just an idea. Thank you. |
👍 thanks for the suggestions |
Some feature requests:
|
Thanks for the suggestions @safaorhan, makes sense indeed. |
Is there a mechanism in place to break this down into stories so I know how to help? I'd love to help make this happen, but don't know exactly what needs to be done. |
Thanks for your offer Walker, help with I've created separate issues for each of these features, labeled https://github.com/josdejong/jsoneditor/issues?q=is%3Aopen+is%3Aissue+label%3Anext Is there an issue that you would like to pick up? The easiest one to get going with |
Hi @josdejong First of all, Thank you for this amazing library. it is literally saving me days of work. Is version 6 ready for prod? or are there things I need to worry about. Also a feature that I would want, but don't see it mentioned yet is to have a color type. I.E if the string entered is a color, display a small box with that color next to it. Thanks for the hard work. |
Thanks @rabbishuki . The Interesting idea on the color picker, can you open a separate issue for that? (else I think that we will forget about it) |
round large number like (100000000000600) to (1000000000000585) fix that? |
@wilddylan that's still an open issue (see #231) |
do u have some ideas about fix that? |
Yes, see #231 (comment) |
I'm working on a completely new version of the JSONEditor. The current code base is hard to maintain and expand, and is too limited qua customization. This new version aims at making the editor extendable (i.e. customize the action menu, custom modes, etc). The new editor will have good support for synchronizing changes with other editors or with a backend via JSON-Patch actions.
Try it out now
The new editor is being built in the next branch. To try it out:
git clone https://github.com/josdejong/jsoneditor.git
cd jsoneditor
next
branch with git:git checkout next
npm install
npm run build
All examples in the
examples
folder are basically working and be tried out.Progress of version
next
patch
and anonChange
listener using JSON-PatchpatchText
andonTextChange
when in modes Text or CodeExtra
The text was updated successfully, but these errors were encountered: