Refactor the internal data structures holding state like expanded nodes, search results, and validation errors #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectionsMap` (WIP)
…ctions to edit (WIP)
…be undefined (WIP)
…InDocumentState` (WIP)
…and tweaking the styling
…n the parent is an Array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves from storing data in a map with keys holding JSONPointers and values holding the state (like the expanded nodes) into a recursive data structure. This requires less logic when operating on the JSON document since the data structures are aligned with that, and it makes improves rendering performance.