Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: text mode loads partially scrolled down" #471

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

cloydlau
Copy link
Contributor

Hello jos,

I think the commit 56e18ee caused this issue: cloydlau/json-editor-vue#95

Reproduction:

<script>
import { JSONEditor } from '../../../lib/index.ts'

let show = true
</script>

<button on:click={() => { show = !show }}>Toggle Visibility: { show }</button>
<div style="height: 100vh;" />
{#if show}
  <JSONEditor mode="text" />
{/if}
image

@josdejong
Copy link
Owner

Thanks! Let's indeed remove this workaround. If a bug fix introduces an other bug its no good.

I did a small test and I couldn't reproduce the original issue where the editor opens scrolled halfway down, so maybe the original issue is resolved.

@josdejong josdejong merged commit 38e7dd9 into josdejong:main Jul 26, 2024
3 checks passed
@josdejong
Copy link
Owner

Published now in v0.23.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants